Merge pull request #1809 from pchaigno/fix-matches-heuristics

Fix error when matching languages against heuristics

lib/linguist/heuristics.rb

@@ -53,7 +53,7 @@ module Linguist
 
     # Internal: Check if this heuristic matches the candidate languages.
     def matches?(candidates)
-      candidates.all? { |l| @languages.include?(l.name) }
+      candidates.any? && candidates.all? { |l| @languages.include?(l.name) }
     end
 
     # Internal: Perform the heuristic

lib/linguist/languages.yml

@@ -1889,7 +1889,6 @@ PHP:
   - .aw
   - .ctp
   - .fcgi
-  - .module
   - .php3
   - .php4
   - .php5

samples/JavaScript/namespace.js

@@ -0,0 +1,93 @@
+(function(root, factory) {
+  if (typeof define === 'function' && define.amd) {
+    define(['lodash'], factory);
+  } else if (typeof exports !== 'undefined') {
+    module.exports = factory(require('lodash'));
+  } else {
+    root.Namespace = factory(root._);
+  }
+})(this, function(_) {
+  'use strict';
+
+  /**
+   * @module namespace
+   * @class namespace
+   */
+  function Namespace() {}
+  
+  /**
+   * Regex for splitting keypaths into arrays.
+   *
+   * @private
+   * @const {RegExp}
+   * @type
+   */
+  var KEYPATH_SPLITTER = /\./g;
+  
+  /**
+   * An internal cache to avoid calculating a keypath more than once.
+   *
+   * @private
+   * @type {Object}
+   */
+  var _keypaths = {};
+  
+  _.extend(Namespace.prototype, {
+  
+    /**
+     * Adds a definition to the namespace object.
+     *
+     * @public
+     * @instance
+     * @method add
+     * @param {String} keypath - The keypath for the definition to be added at.
+     * @param {Function|Object} definition - The definition to be added.
+     * @return {Function|Object} - The definition.
+     */
+    add: function(keypath, definition) {
+      return this._walk(keypath, function(memo, name, index, keypath) {
+        if (index + 1 === keypath.length) {
+          memo[name] = _.extend(definition, memo[name]);
+        }
+        return memo[name] || (memo[name] = {});
+      });
+    },
+  
+    /**
+     * Retrieves a definition from the namespace safely.
+     *
+     * @public
+     * @instance
+     * @method get
+     * @param {String} keypath - The keypath to lookup a definition for.
+     * @returns {Function|Object|undefined} - The definition if it exists, otherwise `undefined`.
+     */
+    get: function(keypath) {
+      return this._walk(keypath);
+    },
+  
+    /**
+     * An internal function for walking a keypath.
+     *
+     * @private
+     * @instance
+     * @method _walk
+     * @param {String} keypath - The keypath to walk through.
+     * @param {Function} [callback] - An optional callback to be called at each item in the path.
+     * @returns {function|Object|undefined} - The reduced keypath.
+     */
+    _walk: function(keypath, callback) {
+      return _.reduce(
+        _keypaths[keypath] || (_keypaths[keypath] = keypath.split(KEYPATH_SPLITTER)),
+        callback || function(memo, name) {
+          return memo && memo[name];
+        },
+        this
+      );
+    }
+  });
+  
+  return Namespace;
+});
+
+//# sourceMappingURL=namespace.js.map

test/test_blob.rb

@@ -469,16 +469,16 @@ class TestBlob < Test::Unit::TestCase
     # Test language detection for files which shouldn't be used as samples
     root = File.expand_path('../fixtures', __FILE__)
     Dir.entries(root).each do |language|
-      next unless File.file?(language)
+      next if language == '.' || language == '..'
 
       # Each directory contains test files of a language
       dirname = File.join(root, language)
       Dir.entries(dirname).each do |filename|
-        next unless File.file?(filename)
-        
         # By default blob search the file in the samples;
         # thus, we need to give it the absolute path
         filepath = File.join(dirname, filename)
+        next unless File.file?(filepath)
+
         blob = blob(filepath)
         assert blob.language, "No language for #{filepath}"
         assert_equal language, blob.language.name, blob.name

test/test_heuristics.rb

@@ -20,6 +20,12 @@ class TestHeuristcs < Test::Unit::TestCase
     Dir.glob("#{samples_path}/#{language_name}/#{file}")
   end
 
+  def test_no_match
+    language = []
+    results = Heuristics.call(file_blob("JavaScript/namespace.js"), language)
+    assert_equal [], results
+  end
+
   # Candidate languages = ["C++", "Objective-C"]
   def test_obj_c_by_heuristics
     # Only calling out '.h' filenames as these are the ones causing issues