Safer popup params to object logic

src/api.ts

@@ -295,9 +295,6 @@ const getRequestStatus = (id, type = undefined) => {
       const { status } = resp;
       if (status === 200) return true;
 
-      const errorMessage = `api error getting request status for id ${id} and type ${type}`;
-      // eslint-disable-next-line no-console
-      console.error(errorMessage);
       return false;
     })
     .catch(err => Promise.reject(err));

src/components/Popup.vue

@@ -48,17 +48,15 @@
     const params = new URLSearchParams(window.location.search);
     params.forEach((value, key) => {
       if (
-        !(
-          key === MediaTypes.Movie ||
-          key === MediaTypes.Show ||
-          key === MediaTypes.Person
-        )
+        key !== MediaTypes.Movie &&
+        key !== MediaTypes.Show &&
+        key !== MediaTypes.Person
       ) {
         return;
       }
 
       _id = Number(params.get(key));
-      _type = MediaTypes[key];
+      _type = key;
     });
 
     return { id: _id, type: _type };

src/components/popup/Person.vue

@@ -23,7 +23,7 @@
         <img
           ref="poster-image"
           class="person-item__img is-loaded"
-          :alt="`Image of ${person.name}`"
+          alt="Image of person"
           :src="poster"
         />
       </figure>

src/modules/popup.ts

@@ -11,9 +11,12 @@ const removeIncludedQueryParams = (params, key) => {
 
 function paramsToObject(entries) {
   const result = {};
-  return entries.forEach((key, value) => {
+  // eslint-disable-next-line no-restricted-syntax
+  for (const [key, value] of entries) {
     result[key] = value;
-  });
+  }
+
+  return result;
 }
 
 const updateQueryParams = (id: number = null, type: MediaTypes = null) => {