Merge pull request #673 from ritiek/release-v1.2.5

Changes for v1.2.5
2025-10-29 18:00:15 +00:00 · 2020-03-02 16:06:54 +05:30 · 2020-03-02 16:04:00 +05:30 · 2020-03-02 15:58:55 +05:30 · 2020-03-02 15:57:09 +05:30 · 2020-03-02 15:49:21 +05:30
4 changed files with 22 additions and 7 deletions
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

 ## [Unreleased]

+## [1.2.5] - 2020-03-02
+### Fixed
+- Skip crash when accessing YouTube-API-only fields in scrape mode ([@ritiek](https://github.com/ritiek)) (#672)
+
+### Changed
+- Changed FFMPEG args to convert to 48k quality audio instead of the current 44k audio. ([@AvinashReddy3108](https://github.com/AvinashReddy3108)) (#667)
+
 ## [1.2.4] - 2020-01-10
 ### Fixed
 - Fixed a crash occuring when lyrics for a track are not yet released
--- a/spotdl/init.py
+++ b/spotdl/init.py
@@ -1 +1 @@
-__version__ = "1.2.4"
+__version__ = "1.2.5"
--- a/spotdl/convert.py
+++ b/spotdl/convert.py
@@ -117,7 +117,7 @@ class Converter:

        if self.input_ext == ".m4a":
            if self.output_ext == ".mp3":
-                ffmpeg_params = "-codec:v copy -codec:a libmp3lame -ar 44100 "
+                ffmpeg_params = "-codec:v copy -codec:a libmp3lame -ar 48000 "
            elif self.output_ext == ".webm":
                ffmpeg_params = "-codec:a libopus -vbr on "
            elif self.output_ext == ".m4a":
@@ -125,12 +125,12 @@ class Converter:

        elif self.input_ext == ".webm":
            if self.output_ext == ".mp3":
-                ffmpeg_params = "-codec:a libmp3lame -ar 44100 "
+                ffmpeg_params = "-codec:a libmp3lame -ar 48000 "
            elif self.output_ext == ".m4a":
-                ffmpeg_params = "-cutoff 20000 -codec:a aac -ar 44100 "
+                ffmpeg_params = "-cutoff 20000 -codec:a aac -ar 48000 "

        if self.output_ext == ".flac":
-            ffmpeg_params = "-codec:a flac -ar 44100 "
+            ffmpeg_params = "-codec:a flac -ar 48000 "

        # add common params for any of the above combination
        ffmpeg_params += "-b:a 192k -vn "
--- a/spotdl/youtube_tools.py
+++ b/spotdl/youtube_tools.py
@@ -109,8 +109,8 @@ def generate_metadata(content):
            "artists": [{"name": None}],
            "name": None,
        },
-        "year": content.published.split("-")[0],
-        "release_date": content.published.split(" ")[0],
+        "year": None,
+        "release_date": None,
        "type": "track",
        "disc_number": 1,
        "track_number": 1,
@@ -122,6 +122,14 @@ def generate_metadata(content):
        "genre": None,
    }

+    # Workaround for
+    # https://github.com/ritiek/spotify-downloader/issues/671
+    try:
+        meta_tags["year"] = content.published.split("-")[0]
+        meta_tags["release_date"] = content.published.split(" ")[0]
+    except pafy.util.GdataError:
+        pass
+
    return meta_tags
Author	SHA1	Message	Date
Ritiek Malhotra	9ecf957c81	Merge pull request #673 from ritiek/release-v1.2.5 Changes for v1.2.5	2020-03-02 16:06:54 +05:30
Ritiek Malhotra	ea4ff29e52	Changes for v1.2.5	2020-03-02 16:04:00 +05:30
Ritiek Malhotra	33e07bea9d	Merge pull request #672 from ritiek/youtube-api-crash Skip Youtube-API-only fields when scraping	2020-03-02 15:58:55 +05:30
Ritiek Malhotra	94e06f99de	Update CHANGELOG	2020-03-02 15:57:09 +05:30
Ritiek Malhotra	9a594d37c7	Skip Youtube-API-only fields when scraping This happens because YouTube recently disabled older API keys for some reason, and so the API key being used internally in Pafy no longer works. See #671 for more information.	2020-03-02 15:49:21 +05:30
Ritiek Malhotra	b45f75b5ca	Merge pull request #667 from AvinashReddy3108/patch-1 Higher bitrate audio conversion.	2020-03-02 10:58:46 +05:30
Avinash Reddy	75114bc26e	Update convert.py	2020-03-01 11:01:54 +05:30
Avinash Reddy	456b404e73	Higher bitrate audio conversion. Changed FFMPEG args to convert to 48k quality audio instead of the current 44k audio. As @hal1200 says: https://github.com/ritiek/spotify-downloader/issues/620#issuecomment-548964142 Might solve the issue here: https://github.com/ritiek/spotify-downloader/issues/620	2020-02-23 11:52:45 +05:30