Merge pull request #673 from ritiek/release-v1.2.5

Changes for v1.2.5

CHANGES.md

@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [1.2.5] - 2020-03-02
+### Fixed
+- Skip crash when accessing YouTube-API-only fields in scrape mode ([@ritiek](https://github.com/ritiek)) (#672)
+
+### Changed
+- Changed FFMPEG args to convert to 48k quality audio instead of the current 44k audio. ([@AvinashReddy3108](https://github.com/AvinashReddy3108)) (#667)
+
 ## [1.2.4] - 2020-01-10
 ### Fixed
 - Fixed a crash occuring when lyrics for a track are not yet released

spotdl/__init__.py

@@ -1 +1 @@
-__version__ = "1.2.4"
+__version__ = "1.2.5"

spotdl/convert.py

@@ -117,7 +117,7 @@ class Converter:
 
         if self.input_ext == ".m4a":
             if self.output_ext == ".mp3":
-                ffmpeg_params = "-codec:v copy -codec:a libmp3lame -ar 44100 "
+                ffmpeg_params = "-codec:v copy -codec:a libmp3lame -ar 48000 "
             elif self.output_ext == ".webm":
                 ffmpeg_params = "-codec:a libopus -vbr on "
             elif self.output_ext == ".m4a":
@@ -125,12 +125,12 @@ class Converter:
 
         elif self.input_ext == ".webm":
             if self.output_ext == ".mp3":
-                ffmpeg_params = "-codec:a libmp3lame -ar 44100 "
+                ffmpeg_params = "-codec:a libmp3lame -ar 48000 "
             elif self.output_ext == ".m4a":
-                ffmpeg_params = "-cutoff 20000 -codec:a aac -ar 44100 "
+                ffmpeg_params = "-cutoff 20000 -codec:a aac -ar 48000 "
 
         if self.output_ext == ".flac":
-            ffmpeg_params = "-codec:a flac -ar 44100 "
+            ffmpeg_params = "-codec:a flac -ar 48000 "
 
         # add common params for any of the above combination
         ffmpeg_params += "-b:a 192k -vn "

spotdl/youtube_tools.py

@@ -109,8 +109,8 @@ def generate_metadata(content):
             "artists": [{"name": None}],
             "name": None,
         },
-        "year": content.published.split("-")[0],
+        "year": None,
-        "release_date": content.published.split(" ")[0],
+        "release_date": None,
         "type": "track",
         "disc_number": 1,
         "track_number": 1,
@@ -122,6 +122,14 @@ def generate_metadata(content):
         "genre": None,
     }
 
+    # Workaround for
+    # https://github.com/ritiek/spotify-downloader/issues/671
+    try:
+        meta_tags["year"] = content.published.split("-")[0]
+        meta_tags["release_date"] = content.published.split(" ")[0]
+    except pafy.util.GdataError:
+        pass
+
     return meta_tags