KevinMidboe/vue-js-modal
1
0
Fork 0
mirror of https://github.com/KevinMidboe/vue-js-modal.git synced 2025-10-29 18:00:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #165 from jjyyxx/master

Browse Source 
Fix a logic bug in toggle method
This commit is contained in:
Yev Vlasenko
2018-02-01 08:59:21 +00:00
committed by GitHub
parent 659a21a605 106f5c9b10
commit 1995797f66
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Modal.vue
View File

@@ -434,12 +434,13 @@ export default {
this.$emit('resize', resizeEvent) this.$emit('resize', resizeEvent)
}, },
/** /**
* Event handler which is triggered on $modal.show and $modal.hight * Event handler which is triggered on $modal.show and $modal.hide
* BeforeEvents: ('before-close' and 'before-open') are `$emit`ed here, * BeforeEvents: ('before-close' and 'before-open') are `$emit`ed here,
* but AfterEvents ('opened' and 'closed') are moved to `watch.visible`. * but AfterEvents ('opened' and 'closed') are moved to `watch.visible`.
*/ */
toggle(state, params) { toggle(state, params) {
const { reset, scrollable, visible } = this const { reset, scrollable, visible } = this
if (visible === state) return
const beforeEventName = visible ? 'before-close' : 'before-open' const beforeEventName = visible ? 'before-close' : 'before-open'
if (beforeEventName === 'before-open') { if (beforeEventName === 'before-open') {